Skip to content

#240 Set object_store minimal version and turn on aws_profile feature #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
houqp merged 2 commits into from
Jan 22, 2023
Merged

#240 Set object_store minimal version and turn on aws_profile feature #247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26e2650
Set object_store minimal version and turn on aws_profile feature
jychen7 Jan 19, 2023
b41d89f
remove unnecessary with_endpoint after upgrade to object_store 0.5.3
jychen7 Jan 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion columnq/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ path = "src/lib.rs"
arrow-schema = { version ="26", features = ["serde"] }

datafusion = "14"
object_store = "0.5.0"
object_store = { version = "0.5.3", features = ["aws_profile"] }
Copy link
Collaborator Author

@jychen7 jychen7 Jan 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the feature aws_profile was introduced since 0.5.2. I set minimum to 0.5.3 as it is latest one as of today and helps remove simplify code a bit in columnq/src/columnq.rs
https://github.com/apache/arrow-rs/blob/master/object_store/CHANGELOG-old.md#object_store_052-2022-12-02

ps: Cargo.lock already use 0.5.3 anyway

roapi/Cargo.lock

Lines 2794 to 2796 in bd168d9

[[package]]
name = "object_store"
version = "0.5.3"

url = "2.2"

log = "0"
Expand Down
6 changes: 0 additions & 6 deletions columnq/src/columnq.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,6 @@ impl ObjectStoreProvider for ColumnQObjectStoreProvider {
// for minio in CI
s3_builder = s3_builder.with_allow_http(true);

// TODO: can remove "with_endpoint" after object_store upgrade to 0.5.3
// https://github.com/apache/arrow-datafusion/pull/4929
if let Ok(endpoint) = std::env::var("AWS_ENDPOINT_URL") {
s3_builder = s3_builder.with_endpoint(endpoint);
}

match s3_builder.build() {
Ok(s3) => Ok(Arc::new(s3)),
Err(err) => Err(DataFusionError::External(Box::new(err))),
Expand Down