Merged
Conversation
13 tasks
houqp
approved these changes
Jan 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
step 2 of #240: replace rusoto_s3 (in use_memory_table: true path) with S3 client from object_store (s3://)
rusoto_s3 is used in
columnq::io::s3andcolumnq::io::s3is used in two places:columnq::partitions_from_table_sourcecolumnq::table::deltawe would like to remove rusoto_s3 and switch to object_store, so can unify S3/GCS/Azure in future
How
this PR (part 1) creates
columnq::io::object_storeand migratecolumnq::partitions_from_table_source.next PR (part 2) will focus on migrating
columnq::table::deltaand deletecolumnq::io::s3completelyTest
Integration tests are improved to include single file and directory.