#240 support s3 direct with ColumnQObjectStoreProvider #241
Merged
houqp merged 9 commits intoroapi:mainfrom Jan 17, 2023
Merged
#240 support s3 direct with ColumnQObjectStoreProvider #241houqp merged 9 commits intoroapi:mainfrom
houqp merged 9 commits intoroapi:mainfrom
Conversation
13 tasks
jychen7
commented
Jan 14, 2023
jychen7
commented
Jan 14, 2023
jychen7
commented
Jan 15, 2023
jychen7
commented
Jan 16, 2023
jychen7
force-pushed
the
227-s3-direct
branch
from
63b7248 to
f027787
Compare
jychen7
commented
Jan 17, 2023
| use datafusion::datasource::object_store::ObjectStoreProvider; | ||
| use url::Url; | ||
|
|
||
| use super::ColumnQObjectStoreProvider; |
Collaborator
Author
There was a problem hiding this comment.
@houqp PR is ready for review, including both unit tests and integration tests
Thanks
houqp
approved these changes
Jan 17, 2023
Member
|
Exciting stuff, thanks @jychen7 ! |
Member
|
I think it's about time to create a new release since there are a lot of improvements added since the last one. @jychen7 do you have any major feature you plan to add before the release. |
Collaborator
Author
|
@houqp no, I think it is good to create a release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
part 1 of #240, also close #227
Why
before this PR, there is error about
Because it creates a new SessionContext and such context have no registry or provider for
s3roapi/columnq/src/table/parquet.rs
Lines 35 to 36 in c0bff95
How
This PR adds ObjectStoreProvider to the "global" SessionContext and pass it down to
columnq/src/table/parquet.rsFor Reviewer
The PR is ready to review with