Merged
Conversation
b732efe to
9a684d5
Compare
65edd63 to
0031b89
Compare
Member
Author
|
@messense do you have a good recommendation on how to cross compile binaries with openssl as a dep? One of the new features we added recently pulled in connectorx, which depends on mysql and postgres crates, so we can't just depend on rustls anymore if we want to enable the database feature for the new releases. |
Contributor
|
Compile openssl from source (i.e vendoring) is the simplest solution, otherwise you'll have to compile a openssl shared library before building the wheel, but then you'll need to bundle the openssl shared library in the wheel to ensure manylinux compatibility which is pretty much the same as compiling from source. |
a49b557 to
c616f3a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.