fix: remove v2 protos, revert to the v1 message set - #77
Merged
Conversation
Drop all */v2 protos and the informer/metrics/resetter/tcp protos added during the Connect-RPC work. Rename lock messages back to Request/Response. The wire format now matches roadrunner-api-dto v1.14.1.
There was a problem hiding this comment.
Pull request overview
This PR removes the Connect-RPC-era proto definitions (including all */v2 protos plus the informer/metrics/resetter/tcp protos) and re-aligns the remaining API surface to the original v1 message set. It also renames the lock messages back to the generic Request/Response names to match the v1 convention.
Changes:
- Delete all
*/v2proto packages (http/kv/jobs/status/service/websockets/applogger) from the API definitions. - Delete Connect-RPC-era plugin protos (informer/metrics/resetter/tcp).
- Rename
LockRequest/LockResponsetoRequest/Responseinlock.v1.
Reviewed changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| roadrunner/api/websockets/v2/websockets.proto | Removes websockets v2 message definitions. |
| roadrunner/api/websockets/v2/response.proto | Removes websockets v2 response message. |
| roadrunner/api/websockets/v2/request.proto | Removes websockets v2 request message and imports. |
| roadrunner/api/tcp/v1/service.proto | Removes TCP v1 request/response protos added with Connect work. |
| roadrunner/api/status/v2/response.proto | Removes status v2 response message. |
| roadrunner/api/status/v2/request.proto | Removes status v2 request message. |
| roadrunner/api/service/v2/service.proto | Removes service v2 shared message definitions. |
| roadrunner/api/service/v2/response.proto | Removes service v2 response messages. |
| roadrunner/api/service/v2/request.proto | Removes service v2 request messages. |
| roadrunner/api/resetter/v1/service.proto | Removes resetter v1 protos added with Connect work. |
| roadrunner/api/metrics/v1/service.proto | Removes metrics v1 proto definitions added with Connect work. |
| roadrunner/api/lock/v1/lock.proto | Renames lock messages back to Request/Response. |
| roadrunner/api/kv/v2/response.proto | Removes KV v2 response message. |
| roadrunner/api/kv/v2/request.proto | Removes KV v2 request message. |
| roadrunner/api/kv/v2/kv.proto | Removes KV v2 item definitions. |
| roadrunner/api/jobs/v2/response.proto | Removes jobs v2 handler response. |
| roadrunner/api/jobs/v2/request.proto | Removes jobs v2 request messages (including push/declare). |
| roadrunner/api/jobs/v2/jobs.proto | Removes jobs v2 job/options/stats proto definitions. |
| roadrunner/api/informer/v1/service.proto | Removes informer v1 proto definitions added with Connect work. |
| roadrunner/api/http/v2/response.proto | Removes HTTP v2 handler response message. |
| roadrunner/api/http/v2/request.proto | Removes HTTP v2 handler request/fetch/batch messages. |
| roadrunner/api/http/v2/http.proto | Removes HTTP v2 header/header-value messages. |
| roadrunner/api/applogger/v2/service.proto | Removes applogger v2 log message definition. |
| roadrunner/api/applogger/v2/applogger.proto | Removes applogger v2 log entry/attrs/response messages. |
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This was referenced Aug 12, 2026
rustatian
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops all
*/v2protos and the informer/metrics/resetter/tcp protos that came in with the Connect-RPC work, and renames the lock messages back toRequest/Response. The remaining v1 protos are wire-identical tov4.24.0, i.e. whatroadrunner-api-dtov1.14.1 is generated from, so released PHP packages work unchanged.Verified with
buf lintand by regenerating api-go: output is byte-identical to the current generated code except for the lock rename.