Skip to content

feat: add txt extension to disable syntax highlighting#386

Merged
riccardoperra merged 2 commits into
mainfrom
385-add-a-way-to-disable-syntax-highlighting
Oct 24, 2022
Merged

feat: add txt extension to disable syntax highlighting#386
riccardoperra merged 2 commits into
mainfrom
385-add-a-way-to-disable-syntax-highlighting

Conversation

@riccardoperra

@riccardoperra riccardoperra commented Oct 23, 2022

Copy link
Copy Markdown
Owner

resolves #385

@riccardoperra riccardoperra linked an issue Oct 23, 2022 that may be closed by this pull request
🚀 - Add a way to disable syntax highlighting #385
Closed
@codesandbox

codesandbox Bot commented Oct 23, 2022

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@changeset-bot

changeset-bot Bot commented Oct 23, 2022 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 19130fc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@riccardoperra riccardoperra changed the title feat: add txt disable syntax highlighting feat: add txt extension to disable syntax highlighting Oct 23, 2022
@riccardoperra riccardoperra marked this pull request as ready for review October 23, 2022 15:33
@riccardoperra riccardoperra temporarily deployed to Preview October 23, 2022 15:35 Inactive
@riccardoperra riccardoperra temporarily deployed to Preview October 23, 2022 15:35 Inactive
@riccardoperra riccardoperra temporarily deployed to Preview October 23, 2022 15:35 Inactive
@github-actions

github-actions Bot commented Oct 23, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Deploy preview for codeimage-ui-dev ready!

✅ Preview
https://codeimage-ui-m786zl9vj-riccardoperra.vercel.app
https://codeimage-ui-pr-386.vercel.app

Built with commit 19130fc.
This pull request is being automatically deployed with vercel-action

@github-actions

github-actions Bot commented Oct 23, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Deploy preview for codeimage-highlight-dev ready!

✅ Preview
https://codeimage-highlight-igq1k2tof-riccardoperra.vercel.app
https://codeimage-highlight-pr-386.vercel.app

Built with commit 19130fc.
This pull request is being automatically deployed with vercel-action

@github-actions

github-actions Bot commented Oct 23, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Deploy preview for codeimage ready!

✅ Preview
https://codeimage-nbhzkapmm-riccardoperra.vercel.app
https://codeimage-ui-pr-386.vercel.app

Built with commit 19130fc.
This pull request is being automatically deployed with vercel-action

EndBug
EndBug suggested changes Oct 23, 2022
View reviewed changes

@EndBug EndBug left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! The only thing I'd suggest would be naming it "Plain Text" instead of "Text", as in VSCode :)

Comment thread packages/config/src/lib/base/languages.ts Outdated
@riccardoperra @EndBug
fix: update txt extension label to Plain text
19130fc 
Co-authored-by: Federico Grandi <fgrandi30@gmail.com>
@riccardoperra riccardoperra temporarily deployed to Preview October 24, 2022 17:24 Inactive
@riccardoperra riccardoperra temporarily deployed to Preview October 24, 2022 17:24 Inactive
@riccardoperra riccardoperra temporarily deployed to Preview October 24, 2022 17:24 Inactive
@riccardoperra riccardoperra merged commit 73dc270 into main Oct 24, 2022
@riccardoperra riccardoperra deleted the 385-add-a-way-to-disable-syntax-highlighting branch October 24, 2022 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@EndBug EndBug EndBug requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🚀 - Add a way to disable syntax highlighting

2 participants

@riccardoperra @EndBug