Conversation
Contributor
|
Looks good. Since the release notes are (partially) autogenerated from PRs, and (more importantly) because it's harder to to review disparate aspects of a single PR, it'd probably be better if you broke this in two or three. The commits look nicely atomic: each would work well as a separate PR (with its own line in the release notes), IMO. For me, changing redis del to unlink is an immediate approval. But although the CSS and JS changes are probably good, they (especially dark mode) require visual inspection which requires extra time from the maintainers. |
Author
|
@nevans thanks and sorry i actually was trying to rebase this and pr into our repo - but if we can merge these upstream that'd be amazing and i'll push a new pr for each feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some nice fixes to make resque web slightly nicer and avoid redis del when we can instead use unlink.