Skip to content

Some nice fixes #1925

Open
taf2 wants to merge 3 commits intoresque:masterfrom
calltracking:new-resque
Open

Some nice fixes #1925
taf2 wants to merge 3 commits intoresque:masterfrom
calltracking:new-resque

Conversation

@taf2
Copy link

@taf2 taf2 commented Dec 10, 2025

Some nice fixes to make resque web slightly nicer and avoid redis del when we can instead use unlink.

@taf2 taf2 changed the title Rebase to upstream origin Some nice fixes Dec 10, 2025
@nevans
Copy link
Contributor

nevans commented Dec 11, 2025

Looks good.

Since the release notes are (partially) autogenerated from PRs, and (more importantly) because it's harder to to review disparate aspects of a single PR, it'd probably be better if you broke this in two or three. The commits look nicely atomic: each would work well as a separate PR (with its own line in the release notes), IMO.

For me, changing redis del to unlink is an immediate approval. But although the CSS and JS changes are probably good, they (especially dark mode) require visual inspection which requires extra time from the maintainers.

@taf2
Copy link
Author

taf2 commented Dec 11, 2025

@nevans thanks and sorry i actually was trying to rebase this and pr into our repo - but if we can merge these upstream that'd be amazing and i'll push a new pr for each feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants