Skip to content

Get rid of Js.t #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cknitt merged 1 commit into from
Dec 11, 2024
Merged

Get rid of Js.t #823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/apis/Global.res
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@val external __DEV__: bool = "__DEV__"

@scope("global") @val
external hermesInternal: option<Js.t<'a>> = "HermesInternal"
external hermesInternal: option<{..}> = "HermesInternal"
6 changes: 3 additions & 3 deletions src/apis/Style.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ external arrayOption: array<option<t>> => t = "%identity"
// Useful if you play with fancy platforms
// Use with caution
@val
external unsafeAddStyle: (@as(json`{}`) _, t, Js.t<'a>) => t = "Object.assign"
external unsafeAddStyle: (@as(json`{}`) _, t, {..}) => t = "Object.assign"

external unsafeStyle: Js.t<'a> => t = "%identity"
external unsafeStyle: {..} => t = "%identity"

type size = string

Expand Down Expand Up @@ -44,7 +44,7 @@ type transform
@obj external skewY: (~skewY: angle) => transform = ""
// @todo matrix

external unsafeTransform: Js.t<'a> => transform = "%identity"
external unsafeTransform: {..} => transform = "%identity"

@unboxed
type transformOriginX =
Expand Down
6 changes: 3 additions & 3 deletions src/apis/Style.resi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ type t
external array: array<t> => t = "%identity"
external arrayOption: array<option<t>> => t = "%identity"
@val
external unsafeAddStyle: (@as(json`{}`) _, t, Js.t<'a>) => t = "Object.assign"
external unsafeStyle: Js.t<'a> => t = "%identity"
external unsafeAddStyle: (@as(json`{}`) _, t, {..}) => t = "Object.assign"
external unsafeStyle: {..} => t = "%identity"

type size

Expand Down Expand Up @@ -39,7 +39,7 @@ type transform
@obj external skewY: (~skewY: angle) => transform = ""
// @todo matrix

external unsafeTransform: Js.t<'a> => transform = "%identity"
external unsafeTransform: {..} => transform = "%identity"

@unboxed
type transformOriginX =
Expand Down
2 changes: 1 addition & 1 deletion src/apis/StyleSheet.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ external absoluteFill: Style.t = "absoluteFill"
external absoluteFillObject: Style.t = "absoluteFillObject"

@module("react-native") @scope("StyleSheet")
external create: Js.t<'a> => Js.t<'a> = "create"
external create: ({..} as 'a) => ({..} as 'a) = "create"
@module("react-native") @scope("StyleSheet")
external flatten: array<Style.t> => Style.t = "flatten"
2 changes: 1 addition & 1 deletion src/components/SectionList.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ external flashScrollIndicators: element => unit = "flashScrollIndicators"
@send external recordInteraction: element => unit = "recordInteraction"

@send
external setNativeProps: (element, Js.t<'a>) => unit = "setNativeProps"
external setNativeProps: (element, {..}) => unit = "setNativeProps"

type props<'sectionData, 'item, 'extraData> = {
ref?: ref,
Expand Down
2 changes: 1 addition & 1 deletion src/elements/NativeMethods.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ module Make = (
external findNodeHandle: T.t => nodeHandle = "findNodeHandle"

@send
external setNativeProps: (T.t, Js.t<'a>) => unit = "setNativeProps"
external setNativeProps: (T.t, {..}) => unit = "setNativeProps"

@send external focus: T.t => unit = "focus"
@send external blur: T.t => unit = "blur"
Expand Down
2 changes: 1 addition & 1 deletion src/elements/ScrollViewMethods.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,5 @@ module Make = (
external flashScrollIndicators: T.t => unit = "flashScrollIndicators"

@send
external setNativeProps: (T.t, Js.t<'a>) => unit = "setNativeProps"
external setNativeProps: (T.t, {..}) => unit = "setNativeProps"
}
Loading