Skip to content

Fix transform origin #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Freddy03h merged 2 commits into from
Dec 10, 2024
Merged

Fix transform origin #821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af5710d
more precise type for transformOrigin
Freddy03h Dec 9, 2024
3d56e81
fix transformOrigin keywords not handled on array syntax
Freddy03h Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions src/apis/Style.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,14 +47,21 @@ type transform
external unsafeTransform: Js.t<'a> => transform = "%identity"

@unboxed
type transformOrigin =
| @as("top") Top
| @as("bottom") Bottom
| @as("left") Left
| @as("right") Right
| @as("center") Center
type transformOriginX =
| @as("0%") Left
| @as("100%") Right
| @as("50%") Center
| Size(size)

@unboxed
type transformOriginY =
| @as("0%") Top
| @as("100%") Bottom
| @as("50%") Center
| Size(size)

type transformOrigin = (transformOriginX, transformOriginY, float)

type resizeMode = [#cover | #contain | #stretch | #repeat | #center]

type fontStyle = [#normal | #italic]
Expand Down Expand Up @@ -255,7 +262,7 @@ type shadowIOSStyle = {
// Transform Props (https://reactnative.dev/docs/transforms#props)
type transformStyle = {
transform?: array<transform>,
transformOrigin?: array<transformOrigin>,
transformOrigin?: transformOrigin,
}

// View styles https://reactnative.dev/docs/view-style-props
Expand Down
21 changes: 14 additions & 7 deletions src/apis/Style.resi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,14 +42,21 @@ type transform
external unsafeTransform: Js.t<'a> => transform = "%identity"

@unboxed
type transformOrigin =
| @as("top") Top
| @as("bottom") Bottom
| @as("left") Left
| @as("right") Right
| @as("center") Center
type transformOriginX =
| @as("0%") Left
| @as("100%") Right
| @as("50%") Center
| Size(size)

@unboxed
type transformOriginY =
| @as("0%") Top
| @as("100%") Bottom
| @as("50%") Center
| Size(size)

type transformOrigin = (transformOriginX, transformOriginY, float)

type resizeMode = [#cover | #contain | #stretch | #repeat | #center]

type fontStyle = [#normal | #italic]
Expand Down Expand Up @@ -243,7 +250,7 @@ type shadowIOSStyle = {
// Transform Props (https://reactnative.dev/docs/transforms#props)
type transformStyle = {
transform?: array<transform>,
transformOrigin?: array<transformOrigin>,
transformOrigin?: transformOrigin,
}

// View styles https://reactnative.dev/docs/view-style-props
Expand Down
Loading