reason-react-native: add example for ScrollView scrollTo method#577
reason-react-native: add example for ScrollView scrollTo method#577
Conversation
|
I used a switch for the example. Btw, I noticed that scrollTo have scrollToParams & that scrollToEndWithOptions have scrollToEndOptions. What do you think about normalising naming with Params or Options (& same for similar places?). @cknitt @sgny We could normalize & deprecate with warnings & remove deprecating warning in next major release? |
|
I think I used the different names on purpose. In the case of Not sure if this is consistent across the code though... |
|
@cknitt I just find confusing the 2 namings. I get the idea. @sgny any comment? |
|
I am open to changing these method args from "params" to "options". Callback params like |
|
I think the function name should remain |
|
I find I'd expect |
|
I would go for just ditching one & keep only the other for simplicity. |
|
If we want to unify this, I am for "Options" everywhere. |
|
How about instead of |
totally wip but better than nothing?