Tweak heuristics to find the project root and "build root"#16
Closed
IwanKaramazow wants to merge 2 commits intomasterfrom
Closed
Tweak heuristics to find the project root and "build root"#16IwanKaramazow wants to merge 2 commits intomasterfrom
IwanKaramazow wants to merge 2 commits intomasterfrom
Conversation
IwanKaramazow
changed the title
Contributor
|
Actually, now looking at the code. my mistake, this seems to behave exactly as expected! |
|
I have checked this branch out, ran a yarn compile, and nothing has changed, is there anything else needed to get this working? |
added 2 commits
December 11, 2020 08:10
The project root means "this is a folder containing node_modules/bs-platform/{platform}/bsc.exe".
This path needs to be correct because it drives the formatter.
The previous heuristics seemed to fail in the case users where using yarn workspaces.
Yarn workspaces seem to have the following layout:
```
/root
/node_modules
- package.json
- yarn.lock
/folder1
/node_modules
- package.json
- bsconfig.json
```
The compiler seems to be located in the `node_modules` under the root and not in the `node_modules` of `folder1`.
By searching for `bscPartialPath` instead of the nearest `bsconfig.json`,
we can correctly determine the root.
the "build root" represents the nearest directory containing a "bsconfig.json" file. "bsconfig.json" can be used to locate the nearest build artefacts and .compiler.log for diagnostics.
IwanKaramazow
force-pushed
the
tweak-project-root-heuristics
branch
from
d535be5 to
57009e5
Compare
Member
|
I think this PR is obsolete due to #59 |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The project root means "this is a folder containing node_modules/bs-platform/{platform}/bsc.exe".
This path needs to be correct because it drives the formatter.
The "build root" represents the nearest directory containing a "bsconfig.json" file. "bsconfig.json" can be used to locate build artefacts and diagnostics.
The previous heuristics seemed to fail in the case users where using yarn workspaces.
Yarn workspaces seem to have the following layout:
The compiler seems to be located in the
node_modulesunder the root and not in thenode_modulesoffolder1.By searching for
bscPartialPathinstead of the nearestbsconfig.json, we can correctly determine the root.However the
bsconfig.jsonindicates the "build root" for the compiler artefacts and diagnostics infolder1.Fixes #10