Stricter number parsing in Float.fromString and Int.fromString#93
Closed
glennsl wants to merge 5 commits intorescript-lang:mainfrom
Closed
Stricter number parsing in Float.fromString and Int.fromString#93glennsl wants to merge 5 commits intorescript-lang:mainfrom
glennsl wants to merge 5 commits intorescript-lang:mainfrom
Conversation
glennsl
changed the title
Contributor
|
Got a big laugh reading this. Especially “worst of all the bad options”. And interesting to learn there is a Number object distinct from the primitive - glad to have that in my toolbox. A couple thoughts… Group them together so the user will see a menu of related choices. So parseString not fromString. If you want to encourage use of your implementation call it In the doc help for each explain the limitations and behavior like “Unreliable behavior if the string includes separators or characters not part of the number.” Give a few bad examples. Point to MDN. |
Contributor
Author
|
Superseded by rescript-lang/rescript#8129 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the changes proposed in #86. See the differences in the tests for specifics on behavioural changes.
Note also that this drops the
radixoption ofInt.toString, but on the other hand improves parsing of radix prefixes in the string itself, i.e.0x,0oand0b.