Do not allow two different package specs with the same suffix#8214
Merged
cknitt merged 2 commits intorescript-lang:masterfrom Jan 22, 2026
Merged
Do not allow two different package specs with the same suffix#8214cknitt merged 2 commits intorescript-lang:masterfrom
cknitt merged 2 commits intorescript-lang:masterfrom
Conversation
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
nojaf
reviewed
Jan 22, 2026
| "name": "dup-suffix-different-in-source", | ||
| "sources": ".", | ||
| "package-specs": [ | ||
| { "module": "esmodule", "in-source": true, "suffix": ".res.js" }, |
Member
There was a problem hiding this comment.
Out of curiosity: when would you want this?
Both in and out source at the same time?
Member
Author
There was a problem hiding this comment.
That's the way it is configured in the root rescript.json in this repo. Maybe this can be cleaned up separately.
Member
There was a problem hiding this comment.
That is because we don't quite have our monorepo story straight in this repository.
Was wondering if you knew a more genuine reason to have this.
Member
Author
|
Don't think this check existed in bsb, but not sure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8177