Move generating AST log to when a module is actually being parsed.#8210
Merged
nojaf merged 3 commits intorescript-lang:masterfrom Jan 21, 2026
Merged
Move generating AST log to when a module is actually being parsed.#8210nojaf merged 3 commits intorescript-lang:masterfrom
nojaf merged 3 commits intorescript-lang:masterfrom
Conversation
cknitt
approved these changes
Jan 21, 2026
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
cknitt
pushed a commit
that referenced
this pull request
Jan 26, 2026
…8210) * Move generating AST log to when a module is actually being parsed. * Add changelog
cknitt
pushed a commit
that referenced
this pull request
Jan 27, 2026
…8210) * Move generating AST log to when a module is actually being parsed. * Add changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that this
Generating AST for module:message for all my files when runningrescript watch -vvfor all files, even when only a single file changed.Rewatch doesn't actually generate AST for all files, only for the dirty ones.
So, this log was a bit misleading.