Fix printing of optional record fields in pattern matching errors#8019
Merged
cknitt merged 4 commits intorescript-lang:masterfrom Nov 18, 2025
Merged
Fix printing of optional record fields in pattern matching errors#8019cknitt merged 4 commits intorescript-lang:masterfrom
cknitt merged 4 commits intorescript-lang:masterfrom
Conversation
cknitt
changed the title
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
cknitt
force-pushed
the
7954
branch
4 times, most recently
from
d0c6eb2 to
5eb2fab
Compare
cristianoc
approved these changes
Nov 18, 2025
Collaborator
cristianoc
left a comment
cristianoc
left a comment
There was a problem hiding this comment.
Looks good, though an optional field of option type is very close to a time bomb.
I would be nearly tempted to issue a warning any time one uses it (that can be silenced in the 0.1% of cases where you actually need it).
The fact that the semantics is NOT what js does, makes it immediately confusing to people anyway.
Member
Author
|
@cristianoc This is not only for optional fields with options. E.g., type t = {b?: result<string, string>}
let f = v =>
switch v {
| {b: Ok(x)} => x
| {b: Error(y)} => y
}currently gives the error |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7954