JSX PPX: externals: React.componentLike -> React.component#7952
Merged
cknitt merged 3 commits intorescript-lang:masterfrom Oct 13, 2025
Merged
JSX PPX: externals: React.componentLike -> React.component#7952cknitt merged 3 commits intorescript-lang:masterfrom
cknitt merged 3 commits intorescript-lang:masterfrom
Conversation
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
Member
Author
|
Eventually we could even get rid of the |
zth
reviewed
Oct 13, 2025
| @@ -1,5 +1,5 @@ | |||
| Hover src/Jsx2.resi 1:4 | |||
| {"contents": {"kind": "markdown", "value": "```rescript\nReact.element\n```\n\n---\n\n```\n \n```\n```rescript\ntype React.element = Jsx.element\n```\nGo to: [Type definition](command:rescript-vscode.go_to_location?%5B%22React.res%22%2C0%2C0%5D)\n"}} | |||
| {"contents": {"kind": "markdown", "value": "```rescript\nprops<string>\n```\n\n---\n\n```\n \n```\n```rescript\ntype props<'first> = {first: 'first}\n```\nGo to: [Type definition](command:rescript-vscode.go_to_location?%5B%22Jsx2.resi%22%2C0%2C0%5D)\n"}} | |||
Member
Author
There was a problem hiding this comment.
No idea why this happens, but now it's back to where it was before #7939, see also the comment there: #7939 (comment)
zth
approved these changes
Oct 13, 2025
Member
zth
left a comment
zth
left a comment
There was a problem hiding this comment.
Just 1 small comment. Great stuff!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSX PPX: Use
React.component<'a>instead ofReact.componentLike<'a, React.element>for external definitions with@react.component.(At the moment, these are still equivalent, but I still hope to eventually be able to make
React componentan abstract type.)