[PoC] support inline/nested records inside of externals#7791
Draft
[PoC] support inline/nested records inside of externals#7791
Conversation
Member
Author
|
cc @nojaf |
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/win32-x64
commit: |
Member
|
This would make writing bindings so much easier!! |
nojaf
reviewed
Aug 25, 2025
| @@ -0,0 +1,9 @@ | |||
| @module("node:fs") | |||
| external readFileSync: (string, ~options: { | |||
| encoding?: [#utf8 | #ascii | #base64], | |||
Member
There was a problem hiding this comment.
Would regular variants also work here?
Member
Author
There was a problem hiding this comment.
Not inline, no. But you could reference a defined one.
Member
|
Beautiful! Ship it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7386
Mostly a PoC for now, to see if it was possible to just extend the current mechanisms to this. Feedback appreciated. There are still issues to solve, but this serves as a base for discussion/experimentation.
Support inline record definitions in externals: