add remainder (% aka modulus) operator#7152
Merged
cometkim merged 4 commits intorescript-lang:masterfrom Nov 9, 2024
Merged
Conversation
cometkim
commented
Nov 8, 2024
Merged
cristianoc
approved these changes
Nov 9, 2024
Collaborator
cristianoc
left a comment
cristianoc
left a comment
There was a problem hiding this comment.
Looks great.
Just need to double-check possible conflicts of adding %.
E.g.3 % raw("0") parses as binary operator. It seems OK, but worth thinking about a little bit.
Member
Author
Yes, I noticed that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Remainder
See also https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Operator_precedence
Resolved #6455