Fix uppercase exotic field format#6897
Merged
cknitt merged 1 commit intorescript-lang:masterfrom Jul 21, 2024
Merged
Conversation
cometkim
changed the title
cristianoc
approved these changes
Jul 21, 2024
| let property_key (s : J.property_name) : string = | ||
| match s with | ||
| | Lit s -> | ||
| let s = Ext_ident.unwrap_uppercase_exotic s in |
Collaborator
There was a problem hiding this comment.
Wondering whether s should have its own type other than string, so that one gets a reminder to do the unwrapping.
Here and in the other cases of ids.
Member
There was a problem hiding this comment.
Good point, can be investigated separately.
Member
|
Thanks a lot for the fix @cometkim! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #6882
The ident format has changed in #6777 for exotic uppercase names, but the change is not applied to the backend in the previous PR.