GenType: support @deriving(accessors)#6537
Merged
cristianoc merged 3 commits intorescript-lang:masterfrom Dec 22, 2023
Merged
Conversation
cometkim
force-pushed
the
preserve-gentype
branch
from
ef65145 to
409dbdb
Compare
cristianoc
approved these changes
Dec 22, 2023
Collaborator
cristianoc
left a comment
cristianoc
left a comment
There was a problem hiding this comment.
Looks great. Did a quick changelog commit to trigger CI.
| | {Location.txt = "genType" | "gentype"; _}, _ -> true | ||
| | _ -> false | ||
|
|
||
| let gentype : attr = ({txt = "genType"; loc = locg}, Ast_payload.empty) |
Collaborator
There was a problem hiding this comment.
looks like this is not used?
Member
Author
There was a problem hiding this comment.
ahhh right. I think it's better to use it instead of copying the original attrs
Member
Author
There was a problem hiding this comment.
done. can you push the changelog commit again? I forgot pull.
cometkim
force-pushed
the
preserve-gentype
branch
from
e16a45c to
d840939
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@cristianoc As I mentioned here, this change makes results of the
@deriving(accessors)ppx are also reflected in genType.This is also important to achieve #6196 later. Because, after all, people want correct typing for the whole JS output.
It's not a difficult change here, but requesting every custom ppx author to add the genType attribute themselves. They cannot accurately determine whether the code uses genType or not (currently genType is pretty dependency-aware)
It makes sense to migrate from #6196 to switch to per-file or per-project genType config. A downward is build speed. Obviously, if genType is enabled on the entire project, it will reduce overall build speed somehow. It needs to be measured IMHO.