fix: set httpOnly on JWT cookie and sanitize scriptJs to prevent stor… - #8051
Open
bshakeel86 wants to merge 1 commit into
Open
fix: set httpOnly on JWT cookie and sanitize scriptJs to prevent stor…#8051bshakeel86 wants to merge 1 commit into
bshakeel86 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
## Description
Fixes a Stored XSS vulnerability in the
scriptJspage field and setshttpOnlyon the JWTsession cookie to prevent token exfiltration.
## Implementation Details
server/helpers/common.js: AddedhttpOnly: truetogetCookieOpts()— preventsclient-side JS from reading the JWT cookie via
document.cookie.server/models/pages.js: Strip<scripttags fromscriptJsbefore storage in bothcreatePageandupdatePage— blocks persistent XSS injection via GraphQL mutations.## Scope of Impact
write:pages+write:scriptspermissions could inject persistent JS executedin any visitor's browser, enabling full account takeover.
## Changelog Highlight
Fixed Stored XSS in page scripts field; JWT cookie now flagged
httpOnly.