Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: reo7sp/tgbot-cpp
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.8
Choose a base ref
...
head repository: reo7sp/tgbot-cpp
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.9
Choose a head ref
  • 14 commits
  • 12 files changed
  • 6 contributors

Commits on Jun 10, 2024

  1. Configuration menu
    Copy the full SHA
    34558bc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5a6b1fc View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. Update LICENSE

    reo7sp authored Jun 13, 2024
    Configuration menu
    Copy the full SHA
    faafa5e View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. fix CurlHttpClient.cpp

    fix: `makeRequest` didn't add `url.query` to `u` when it is sending a GET request
    AtomAlpaca authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    d2f1a78 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #317 from AtomAlpaca/master

    fix CurlHttpClient.cpp
    reo7sp authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    da74ac4 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2025

  1. support boost-1.87.0

    miyanyan committed Jan 18, 2025
    Configuration menu
    Copy the full SHA
    0a89870 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #328 from miyanyan/boost-1.87.0

    support boost-1.87.0
    reo7sp authored Jan 18, 2025
    Configuration menu
    Copy the full SHA
    0aba021 View commit details
    Browse the repository at this point in the history
  3. I noticed that the onSuccessfulPayment method is not available in the…

    … current version of the tgbot-cpp library. This makes it challenging to handle successful payment events directly using the library.
    
    Could you let me know if there are any plans to add this method in future updates? If yes, when can we expect it to be implemented?
    
    Thank you for your work on this library, and I look forward to your response!
    
    Best regards,
    Gorillza committed Jan 18, 2025
    Configuration menu
    Copy the full SHA
    cbe762b View commit details
    Browse the repository at this point in the history
  4. I removed the extra additions in CMaleList.txt and added #include "tg…

    …bot/types/SuccessfulPayment.h"
    Gorillza committed Jan 18, 2025
    Configuration menu
    Copy the full SHA
    61a691e View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2025

  1. Merge pull request #330 from Gorillza/master

    I noticed that the onSuccessfulPayment method is not available in the…
    reo7sp authored Jan 19, 2025
    Configuration menu
    Copy the full SHA
    f88c332 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2025

  1. net: Allow curl handle in CurlHttpClient to be kept alive

    The `CurlHttpClient` currently produces an excessive number of
    `connect()` syscalls, as every `makeRequest` creates a new TCP
    connection. This inefficiency becomes particularly evident with
    `TgLongPoll`, which continuously calls `getUpdates` in an endless loop,
    creating a relentless cycle of `connect()` and `close()` operations.
    
    A more sensible approach is to reuse HTTP connections by keeping them
    alive across multiple requests. I suggest modifying the implementation
    to allow the curl handle to persist until the `CurlHttpClient` object is
    destroyed.
    
    For thread safety, we can maintain a
    `std::unordered_map<std::thread::id, CURL*> curlHandles` within the
    `CurlHttpClient` class, ensuring each thread gets its own handle.
    
    After all, treating connections like disposable napkins doesn't exactly
    scream efficiency.
    
    Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
    ammarfaizi2 committed Jan 21, 2025
    Configuration menu
    Copy the full SHA
    775291f View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2025

  1. Merge pull request #331 from ammarfaizi2/curl-keep-alive

    Allow curl handle in `CurlHttpClient` to be kept alive
    reo7sp authored Jan 26, 2025
    Configuration menu
    Copy the full SHA
    3bef4dc View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2025

  1. Added functionality to handle onSuccessfulPayment through Update with…

    …out cyclic execution. Modified the method to include not only payment information but also the entire message, allowing access to id and other fields for better handling of successful payment events.
    Gorillza committed Feb 2, 2025
    Configuration menu
    Copy the full SHA
    342773b View commit details
    Browse the repository at this point in the history
  2. Merge pull request #335 from Gorillza/hotfix

    Added functionality to handle onSuccessfulPayment through Update with…
    reo7sp authored Feb 2, 2025
    Configuration menu
    Copy the full SHA
    1b10d2f View commit details
    Browse the repository at this point in the history
Loading