Add physics support for live2d models#6818
Open
ronchonbon wants to merge 5 commits into
Open
Conversation
|
Absolutely incredible implementation for all Live2D devs, almost obligatory since baking physics during the animation process usually lead to strange results. I really hope @renpytom checks it out and this goes live as soon as possible. Thank you so much for this. |
Contributor
|
Wow! Waited so long for this! Any updates on this? |
Contributor
Author
|
Probably not a priority while 8.5.3/8.6.0 are being worked up, but the changes are drop-in compatible with both |
Member
|
I'd expect this to go in right after 8.5.3 is out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #4614, re-implementation of Live2D physics support in Cython.
I use an alternate formulation of Live2DModel for my projects with a different flow, but I've placed the example call to
evaluate_physicsin I think a logical place withinLive2D.render- as the last call after parameters have been updated by theupdate_functionpipeline.This placement does have a downside: because Live2D physics operates on parameters, any modification of a physics-affected parameter by
update_functionor an expression will be overridden by the physics engine, leading to glitchy movement. The most obvious workaround is to only manually set non-physics parameters. There are relatively simple alternate workflows if you want a parameter to have both physics and be manually settable, which I'm happy to discuss with anyone who's interested.