Implement priority sorting logic for LearnEth tutorials #6504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for reliable-cocada-166884 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
yann300
reviewed
Nov 3, 2025
| }, | ||
| }, | ||
| effects: { | ||
| *loadRepo({ payload }, { put, select }) { |
There was a problem hiding this comment.
That’s right. This was written temporarily to use mock data, so please just check the priority logic. I’ll roll it back later.
hsy822
force-pushed
the
ordering-tutorials-in-learneth
branch
from
0c026cb to
f717126
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6501
This PR implements the new sorting logic for LearnEth tutorials as requested and sets the filter panel to be open by default.
Key Changes
Home/index.tsx):Level(asc)priority(asc, lower numbers first)name(alphabetical)priorityare sorted last, alphabetically by name.Home/index.tsx):showFilterstotrue.workshop.ts):.ymlfiles are not yet updated with thepriorityfield, I have added mock data inworkshop.tsto allow for immediate testing.loadRepofunction is commented out, and a temporaryloadRepois used to inject this mock data..ymlfiles are updated and deployed,workshop.tscan be easily reverted (uncomment original function, delete mock data).@ryestew Please review the new sorting logic and the default filter state.