Skip to content

Upgrade react router 4 - #5

Merged
remarkablemark merged 3 commits into
remarkablemark:upgrade-react-router-4from
moshie:upgrade-react-router-4
Aug 2, 2017
Merged

Upgrade react router 4#5
remarkablemark merged 3 commits into
remarkablemark:upgrade-react-router-4from
moshie:upgrade-react-router-4

Conversation

@moshie

@moshie moshie commented Jul 26, 2017

Copy link
Copy Markdown

No description provided.

@moshie moshie mentioned this pull request Jul 26, 2017
@remarkablemark

Copy link
Copy Markdown
Owner

@moshie Thanks for making the new pull request.

I noticed that some areas that have been refactored to ES6 class and import/export have been undone/reverted. Do you mind amending your commits so that the ES6 changes are kept?

And could you also make a few styling tweaks:

  • End each file with a newline (follow the Unix EOL convention)
  • Capitalize component filename (rename views/app.jsx to views/App.jsx)

Once again, much appreciated for the time and effort on this.

@moshie

moshie commented Jul 28, 2017

Copy link
Copy Markdown
Author

@remarkablemark No worries

I have made the changes you requested.

Babel wraps the es6 components in an object making them only accessible from the default property which is the reason for this var App = require('../views/App.jsx').default; in client.js & routes/index.jsx.

Hope this is ok this is the only way I could get this to work without mixing es6 & es5.

@remarkablemark

Copy link
Copy Markdown
Owner

@moshie Thanks for the update. I'll continue the ES6 refactor in a future commit.

@remarkablemark
remarkablemark merged commit 3460659 into remarkablemark:upgrade-react-router-4 Aug 2, 2017
@moshie
moshie deleted the upgrade-react-router-4 branch January 14, 2018 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants