Skip to content

Updated react and router - #4

Closed
moshie wants to merge 1 commit into
remarkablemark:upgrade-react-routerfrom
moshie:upgrade-react-router
Closed

Updated react and router#4
moshie wants to merge 1 commit into
remarkablemark:upgrade-react-routerfrom
moshie:upgrade-react-router

Conversation

@moshie

@moshie moshie commented Jul 20, 2017

Copy link
Copy Markdown

No description provided.

@remarkablemark

Copy link
Copy Markdown
Owner

@moshie I appreciate the pull request.

Do you mind cherry-picking the changes over to the branch upgrade-react-router-4, which has the latest code from master? This will ensure consistency between my tutorials.

Also, do you mind not bumping react and react-dom and not committing yarn.lock or package-lock.json? I'm thinking about doing those tasks separately in one of my later tutorials. Thanks!

@moshie

moshie commented Jul 24, 2017

Copy link
Copy Markdown
Author

@remarkablemark No Problem, been enjoying the tutorials!

Yeah sure thing, I'll make those changes on the upgrade-react-router-4 hopefully some time later if not tommorow 👍

@remarkablemark

Copy link
Copy Markdown
Owner

@moshie Thanks for taking the time to do this.

When I do get to making the video, what's the best way that I can give you credit for your contribution? Would a link to your GitHub work?

@moshie

moshie commented Jul 26, 2017

Copy link
Copy Markdown
Author

Hope this is all ok!

A link to my github would be cool thanks 👍

@moshie moshie closed this Jul 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants