notifications-ui - Warn against "oldest first" sort#9718
Open
fregante wants to merge 1 commit into
Open
Conversation
fregante
changed the title
notifications-ui warn of oldestnotifications-ui - Warn against oldest sort
fregante
changed the title
notifications-ui - Warn against oldest sortnotifications-ui - Warn against "oldest first" sort
fregante
commented
Jun 8, 2026
| } | ||
|
|
||
| function init(): void { | ||
| for (const dropdown of $$(['.notification-sort-by', '.notification-group-by'])) { |
Member
Author
There was a problem hiding this comment.
Not sure why the observer was not used here. If we have issues on slow connections we should just implement element-ready's waitForChildren logic
| label.replaceChildren( | ||
| <span className='fgColor-severe'>Oldest first</span>, | ||
| <SortAscIcon className='fgColor-severe' />, | ||
| ); |
| {buttons.map(button => transform(button))} | ||
| </ul> | ||
| </segmented-control> | ||
| </segmented-control>, |
Member
Author
There was a problem hiding this comment.
No changes here other than just extracting this callback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
notifications-ui- highlight "oldest" as "bad" option #9656Test URLs
https://github.com/notifications
Screenshot
the other benefit is that on mobile it's also shorter vertically