Repository navigation
conversation-activity-filter - Turn into svelte component - #9675
Merged
Merged
Conversation
fregante
requested changes
Jun 2, 2026
Member
|
This doesn't save bytes, but it helps keep the feature readable by extracting the large component's markup to a dedicated file. For example it only now occurred to me that we're doing so much work on the page even when none of this is needed most of the time. I'll look into activating the comment observer only after the user picks an option from the menu.
|
conversation-activity-filter - Turn into svelte component
fregante
marked this pull request as ready for review
June 2, 2026 06:36
fregante
approved these changes
Jun 2, 2026
fregante
reviewed
Jun 2, 2026
Member
|
To maintainers: Please add labels to this PR |
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.