clean-conversation-headers - Update and improve#9628
Conversation
| /* Hide "from" */ | ||
| :is(span[data-component='Tooltip'], button[id^='ref-picker']) | ||
| + span:not([class]) { | ||
| font-size: 0; |
There was a problem hiding this comment.
This was a hacky way to target all element-less text nodes. Unfortunately they still existed in the DOM and caused invisible wrapping zones.
Since the feature already does substantial JS alterations, it doesn't make sense to rely on these hacks. JS also has safer methods to avoid bad text node matches (removeTextNodeContaining, assertNodeContent) which we were already using to target from anyway
| font-size: 14px; | ||
| } | ||
|
|
||
| --margin: 4px; |
There was a problem hiding this comment.
Not sure why we needed this. Unless it's a single ml-1 class, let's just prefer gap
Native
This PR
|
Native
This PR
Possible alternativeAdding a bunch of 
I'll just hope someone at GitHub notices this crappy layout and uses the one I proposed in #9166 
|
|
To maintainers: Please add labels to this PR |
fregante
changed the title
clean-conversation-headers - Refactorclean-conversation-headers - Update and improve
1 participant
Followup to #9166 and #9627
clean-conversation-headersre-order #9505The code for
clean-conversation-headersis messy and it's causing some wrapping issues in the area.conversation-activity-filteralso adds its own wrapper, making the DOM even more flimsy.