Meta: Cleanup some TODOs by fregante · Pull Request #9545 · refined-github/refined-github

fregante · 2026-05-20T15:23:01Z

follows Meta: silence delayed TODOs #9538

Current output

These are covered by:

/source/features/open-all-conversations.tsx
  14:3  warning  There is a TODO that is past due date: 2026-01-01. Pre-React selector; Drop  unicorn/expiring-todo-comments
  24:4  warning  There is a TODO that is past due date: 2026-01-01. Pre-React selector; Drop  unicorn/expiring-todo-comments
  39:2  warning  There is a TODO that is past due date: 2026-01-01. Pre-React selector; Drop  unicorn/expiring-todo-comments
  51:3  warning  There is a TODO that is past due date: 2026-01-01. Pre-React selector; Drop  unicorn/expiring-todo-comments
  75:4  warning  There is a TODO that is past due date: 2026-01-01. Pre-React selector; Drop  unicorn/expiring-todo-comments

/source/features/selection-in-new-tab.tsx
  12:3  warning  There is a TODO that is past due date: 2025-07-01. Drop  unicorn/expiring-todo-comments

/source/features/vertical-front-matter.tsx
  39:4  warning  There is a TODO that is past due date: 2026-03-01. remove  unicorn/expiring-todo-comments

✖ 9 problems (0 errors, 9 warnings)

fregante · 2026-05-20T15:23:34Z

 	}
 }

-// TODO: Use native highlighting https://github.com/refined-github/refined-github/pull/6909#discussion_r1322607091


🥲

⚠️ releases-tab, bugs-tab, clean-repo-tabs broken #8867

fregante · 2026-05-20T15:24:22Z

 							<div className="flex-auto">{description}</div>
 							<div className="ml-2 no-wrap">
-								{splitKeys(hotkey)}
+								{joinJsx(' ', hotkey.split(' ').map(key => <kbd>{key}</kbd>))}


Forgot in #9537

fregante · 2026-05-20T15:25:40Z

 		[
-			'.js-issue-title', // TODO [2026-01-01]: Drop
 			'[data-component="TitleArea"] .markdown-title', // Issue and PR React View Title
-			'.discussion-sidebar-item:has(.octicon-issue-opened) p', // Discussions sidebar item


Implemented by GitHub

fregante · 2026-05-20T15:26:07Z

 			?? radio.nextSibling!
 		);
 		const tooltip = $([
-			// TODO [2025-05-01]: Remove


Dead features don't need TODOs

one-click-review-submission doesn't work #8711

fregante · 2026-05-20T16:13:22Z

Current status, including non-dated TODOs restored. Many already have open PRs, some should just be fixed, we still have a lot :)


build/features.test.ts
  36:37  warning  TODO: Add side-by-side gif'     unicorn/expiring-todo-comments
  37:31  warning  TODO: side-by-side png'         unicorn/expiring-todo-comments
  38:26  warning  TODO: TODO Add gif with key overlay'  unicorn/expiring-todo-comments
  39:22  warning  TODO: Add side-by-side png'     unicorn/expiring-todo-comments

eslint.config.js
   48:6  warning  TODO: ...'                                  unicorn/expiring-todo-comments
  127:5  warning  TODO: Drop after moving to dprint'    unicorn/expiring-todo-comments
  305:3  warning  TODO: Use global `/flat` config....'  unicorn/expiring-todo-comments
  347:3  warning  TODO: Use global `/flat` config'      unicorn/expiring-todo-comments

rollup.config.js
  67:2  warning  TODO: Drop after...'  unicorn/expiring-todo-comments

source/features/action-used-by-link.tsx
  28:2  warning  TODO: Integrate style better...'  unicorn/expiring-todo-comments

source/features/clean-repo-sidebar.tsx
  11:1  warning  TODO: It's broken'  unicorn/expiring-todo-comments

source/features/collapsible-content-button.tsx
  64:2  warning  TODO: ensure it's added only once before...'  unicorn/expiring-todo-comments

source/features/conversation-activity-filter.tsx
  329:3  warning  TODO: remove once the issue is resolved'  unicorn/expiring-todo-comments

source/features/copy-on-y.tsx
  20:1  warning  TODO: Add visual popup, maybe use...'  unicorn/expiring-todo-comments

source/features/default-branch-button.tsx
  50:2  warning  TODO: Move to excludes after...'  unicorn/expiring-todo-comments

source/features/no-self-reference.tsx
  24:2  warning  TODO: Revert #9086 once #6554 is...'  unicorn/expiring-todo-comments

source/features/open-all-conversations.tsx
  14:3  warning  There is a TODO that is past due date: 2026-01-01. Pre-React selector; Drop  unicorn/expiring-todo-comments
  24:4  warning  There is a TODO that is past due date: 2026-01-01. Pre-React selector; Drop  unicorn/expiring-todo-comments
  39:2  warning  There is a TODO that is past due date: 2026-01-01. Pre-React selector; Drop  unicorn/expiring-todo-comments
  51:3  warning  There is a TODO that is past due date: 2026-01-01. Pre-React selector; Drop  unicorn/expiring-todo-comments
  75:4  warning  There is a TODO that is past due date: 2026-01-01. Pre-React selector; Drop  unicorn/expiring-todo-comments

source/features/releases-tab.tsx
  112:2  warning  TODO: remove once the issue is resolved'  unicorn/expiring-todo-comments

source/features/selection-in-new-tab.tsx
  12:3  warning  There is a TODO that is past due date: 2025-07-01. Drop  unicorn/expiring-todo-comments

source/features/status-subscription.tsx
  246:3  warning  TODO: remove once the issue is resolved'  unicorn/expiring-todo-comments

source/features/suggest-commit-title-limit.tsx
  47:25  warning  TODO: Old `isPR` view - TODO: Remove after...'  unicorn/expiring-todo-comments

source/features/unreleased-commits.tsx
  53:4  warning  TODO: Review or drop optional chaining,...'  unicorn/expiring-todo-comments

source/features/vertical-front-matter.tsx
  39:4  warning  There is a TODO that is past due date: 2026-03-01. remove  unicorn/expiring-todo-comments

source/github-helpers/api.tsx
  282:2  warning  TODO: Remove automatic usage of globals...'  unicorn/expiring-todo-comments

source/github-helpers/github-file-url.ts
  43:3  warning  TODO: `getCurrentGitRef` uses global...'  unicorn/expiring-todo-comments

source/github-helpers/is-conversation-locked.ts
  46:3  warning  TODO: Add AbortSignal after...'  unicorn/expiring-todo-comments

source/github-helpers/selectors.test.ts
  66:4  warning  TODO: ? Use snapshot with outerHTML[]'  unicorn/expiring-todo-comments

source/github-helpers/selectors.ts
  30:2  warning  TODO: Use Puppeteer?'  unicorn/expiring-todo-comments
  44:2  warning  TODO: Use Puppeteer?'  unicorn/expiring-todo-comments

source/helpers/abortable-classname.ts
  3:1  warning  TODO: Drop after...'  unicorn/expiring-todo-comments

source/options.tsx
  26:2  warning  TODO: Add support for GHE'  unicorn/expiring-todo-comments

source/options/reload-without.ts
  24:3  warning  TODO: Use...'  unicorn/expiring-todo-comments

source/options/token-validation.tsx
  103:3  warning  TODO: Fix upstream bug...'  unicorn/expiring-todo-comments

fregante

Ready

fregante · 2026-05-20T16:17:24Z

 	include: [
 		pageDetect.isConversation,
-		// Workaround for #6554
+		// Workaround for https://github.com/refined-github/refined-github/issues/6554


Issue references are hard to use especially due to the broken linkify-code. I've only been using them when they add information. "Workaround for X" doesn't have enough information, I have to click the link to read the full comment.

fregante · 2026-05-20T17:37:45Z

So most of the changes actually just remove or postpone the TODOs. Only improve-shortcut-help saw significant code deletion; linkify-text also dropped one selector.

Individual PRs welcome to actually address the issues

fregante added 3 commits May 20, 2026 23:10

DO some TO

15bbc1b

Bump 'em

b56e719

uhmn

f1192be

fregante changed the title ~~DO some TO~~ Meta: Address some TODOs May 20, 2026

github-actions Bot added the meta Related to Refined GitHub itself label May 20, 2026

SunsetTechuila reviewed May 20, 2026

View reviewed changes

Comment thread source/features/improve-shortcut-help.tsx Resolved

fregante commented May 20, 2026

View reviewed changes

fregante added 4 commits May 20, 2026 23:56

Drop expired code

173f980

/2

56cf237

Drop, update more

decb62b

/2

8b44afa

fregante marked this pull request as ready for review May 20, 2026 16:11

/3

4b5a9d1

fregante added 2 commits May 21, 2026 00:13

/4

1c98beb

/5

cf99866

fregante commented May 20, 2026

View reviewed changes

fregante changed the title ~~Meta: Address some TODOs~~ Meta: Cleanup some TODOs May 20, 2026

Last

6f57fe2

fregante enabled auto-merge (squash) May 20, 2026 17:38

fregante merged commit 4d079bf into main May 20, 2026
9 checks passed

SunsetTechuila deleted the todo-done branch May 21, 2026 07:18

Navigation Menu

Repository navigation

Meta: Cleanup some TODOs - #9545

Meta: Cleanup some TODOs#9545
fregante merged 11 commits into
mainfrom
todo-done

fregante commented May 20, 2026

Uh oh!

Uh oh!

fregante May 20, 2026

Uh oh!

fregante May 20, 2026

Uh oh!

fregante May 20, 2026

Uh oh!

fregante May 20, 2026

Uh oh!

fregante commented May 20, 2026 •

edited

Loading

Uh oh!

fregante left a comment

Uh oh!

fregante May 20, 2026

Uh oh!

fregante commented May 20, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

Conversation

fregante commented May 20, 2026

Current output

Uh oh!

Uh oh!

fregante May 20, 2026

Choose a reason for hiding this comment

Uh oh!

fregante May 20, 2026

Choose a reason for hiding this comment

Uh oh!

fregante May 20, 2026

Choose a reason for hiding this comment

Uh oh!

fregante May 20, 2026

Choose a reason for hiding this comment

Uh oh!

fregante commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fregante left a comment

Choose a reason for hiding this comment

Uh oh!

fregante May 20, 2026

Choose a reason for hiding this comment

Uh oh!

fregante commented May 20, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

fregante commented May 20, 2026 •

edited

Loading