Meta: Fix @typescript-eslint/naming-convention errors#9135
Meta: Fix @typescript-eslint/naming-convention errors#9135SunsetTechuila wants to merge 8 commits intorefined-github:mainfrom
@typescript-eslint/naming-convention errors#9135Conversation
|
We can also disable only snake and kebab cases: #9133 (comment) |
fregante
left a comment
fregante
left a comment
There was a problem hiding this comment.
Yessss, thank you! Those changes were sort of grandfathered in for a few reasons, but were not meant to stay that way.
|
Changing |
|
Everything has been rechecked and all review comments have been addressed 
|
source/options-storage.ts
Outdated
| options.logHttp = options.logHTTP; | ||
| options.customCss = options.customCSS as unknown as string; |
There was a problem hiding this comment.
of this should be
options.logHttp = options.logHTTP ?? options.logHttp;
options.customCss = options.customCSS as unknown as string ?? options.customCss;?
There was a problem hiding this comment.
Check the docs, it should look for the old key, assign it to the new one and then delete it
There was a problem hiding this comment.
and then delete it
doesn't OptionsSyncPerDomain.migrations.removeUnused handle that?
|
Complaining about things in every comment is diabolical and it gets old. If you don't want to do it, don't do it. |
If this is about this PR - I dislike not being able to see some linting errors before I push more than renaming If this is in general - I haven't run out of patience yet, and I still like the extension more than I dislike the DX.
I'm doing this in hope you make at least some defaults more sane or override them. |
2 participants
Makes struggling less constant: #9133 (comment)
Makes DX inside the IDE less insufferable
Test URLs
Screenshot