netiquette - Suggest to open discussion if possible#9076
netiquette - Suggest to open discussion if possible#9076SunsetTechuila wants to merge 3 commits intomainfrom
netiquette - Suggest to open discussion if possible#9076Conversation
SunsetTechuila
changed the title
netiquette - suggest to open discussion if possiblenetiquette - Suggest to open discussion if possible
fregante
left a comment
fregante
left a comment
There was a problem hiding this comment.
Eh, not a fan of discussions in general, but I guess some repo may prefer them.
To be honest I'd wait until someone complains before adding this. What if you add "open discussion" only when issues are disabled?
| || looseParseInt($optional('[aria-label*="other participants"]')?.ariaLabel) > 30 | ||
| || elementExists('[data-testid="issue-timeline-load-more-count-front"]') | ||
| // TODO: Drop in April 2025; old conversation style | ||
| // TODO: Drop in 2026; old conversation style |
There was a problem hiding this comment.
Netiquette generally applies to open source products. I'm totally okay with dropping old-GHE support this week.
| '.GlobalNav', | ||
| // Remove after June 2026 | ||
| '.js-repo-nav', | ||
| ].join(',')}`; |
There was a problem hiding this comment.
Parens missing. This is why I dislike template literals for short strings 🥹
I'd extract this to its own selector helper function, like is('div', 'span') === ':is(div,span)'
Do you know any such repos? I only know about the ones where issues are automatically closed if they were created without prior discussion, but that's not something we can check. I think this PR should be merged as is or not merged at all. |
fregante
left a comment
fregante
left a comment
There was a problem hiding this comment.
Let's also exclude the feature on GHE, in a separate PR
2 participants
+ addresses #9028 (comment)
Test URLs
eslint/eslint#20304
#6 (nothing changed)
Screenshot