sticky-sidebar - Enable on more pages#9037
Conversation
SunsetTechuila
changed the title
sticky-sidebar - Enable on profile pagessticky-sidebar - Enable on user profile pages
SunsetTechuila
changed the title
sticky-sidebar - Enable on user profile pagessticky-sidebar - Enable on profile pages
SunsetTechuila
changed the title
sticky-sidebar - Enable on profile pagessticky-sidebar - Enable on profile & settings pages
SunsetTechuila
changed the title
sticky-sidebar - Enable on profile & settings pagessticky-sidebar - Enable on more pages
Mostly because verifying that they work and keeping them working in the future becomes prohibitive. Also because if any of these break catastrophically (e.g. crashes the repo settings page) then we have to hotfix/disable the feature everywhere. |
| '.Layout-sidebar .BorderGrid', // `isRepoRoot` | ||
| '.repository-content .Layout-sidebar .BorderGrid', // `isRepoRoot` | ||
| '.Layout-sidebar #partial-discussion-sidebar', // Old `isConversation` | ||
| 'div[data-testid="issue-viewer-metadata-pane"]', // `isConversation` | ||
| '#discussion_bucket #partial-discussion-sidebar', // `isDiscussion` | ||
| '.page-profile .h-card', // `isUserProfile` | ||
| '.orghead + div .gutter-lg > :nth-child(2) > *', // `isOrganizationProfile`, | ||
| 'navigation-list[data-turbo-frame="settings-frame"]', // `isUserSettings` | ||
| 'div:has(> nav[aria-label="General settings"])', // `isRepoSettings` | ||
| '.wiki-rightbar', | ||
| '.discussions-header-wrap + div .Layout-sidebar > *', // `isDiscussionList` |
There was a problem hiding this comment.
It should be possible to replace a good portion of these selectors with .Layout-sidebar
| User settings: https://github.com/settings/profile | ||
| Repo settings: https://github.com/refined-github/refined-github/settings | ||
| Wiki: https://github.com/refined-github/refined-github/wiki/Contributing | ||
| Discussion list: https://github.com/eslint/eslint/discussions |
There was a problem hiding this comment.
Honestly I'm not excited about this long list and I'd rather not add support. The repo home and the conversation sidebar are heavily used every day; these other pages are tangential at best. Supporting (and making future changes) to a feature that affects 12 different layouts sounds like a pain. So let's undo this part and keep the improved variables, if they actually improve something.
There was a problem hiding this comment.
What if I remove settings and organization profile? Still no?
2 participants
Because why not. That's better than leaving the space empty. Feel free to close without comments if you disagree.
I'll extract cleanup and improvements from #8979 to a separate PR once this PR is closed or merged.
Test URLs
https://github.com/fregante
https://github.com/refined-github
https://github.com/settings/profile
https://github.com/refined-github/refined-github/settings
https://github.com/refined-github/refined-github/wiki/Contributing
https://github.com/eslint/eslint/discussions
Screenshot