sticky-sidebar - Restore feature#8979
Conversation
| @@ -27,26 +20,15 @@ Exclusively use simple sums and use `0px` instead of `0` | |||
| /* It needs to be on the same element as above for calc() to work */ | |||
| --rgh-sticky-notification-header-height: 69px; | |||
There was a problem hiding this comment.
We can use --base-sticky-header-height GH variable. sticky-comment-header already does
| [id^='my-forks-menu'] { | ||
| z-index: initial !important; /* This affects the social buttons. It seems to have no effect but it constantly causes trouble with other features. */ | ||
| } | ||
|
|
| /* Hides the last divider (on pull requests) to avoid https://user-images.githubusercontent.com/10238474/62282128-af6fb980-b457-11e9-8b18-c29687b88da1.gif */ | ||
| .rgh-sticky-sidebar + .border-top { | ||
| display: none; | ||
| } |
| /* required to make `sticky` work for the issue Sidebar */ | ||
| .rgh-sticky-sidebar-container { | ||
| display: unset !important; | ||
| } |
| '.Layout-sidebar #partial-discussion-sidebar', // Old `isConversation` | ||
| 'div[data-testid="issue-viewer-metadata-pane"]', // `isConversation` | ||
| '#discussion_bucket #partial-discussion-sidebar', // `isDiscussion` | ||
| 'div[data-testid="issue-viewer-metadata-pane"]', // Issue `isConversation`. TODO: Remove after March 2026 |
There was a problem hiding this comment.
Issue sidebar is natively sticky for at least 5 months: #8696
SunsetTechuila
changed the title
sticky-sidebar - Restore on PR conversation pagesticky-sidebar - Restore feature
|
@fregante ready to be reviewed |
|
This is one of those I'm not sure about since it's toggling a native class. Why that change? Does the sidebar stick natively or not? I'm confused there |
It doesn't |
|
Your previous comment suggests that it's natively enabled on issues and the Also again it's not clear why you switched from the rgh class to a non rgh class. Why? Can that change be reverted? |
That's right
What should be updated, and in what way?
For me, adding the |
The feature shouldn't run on issues.
No. If you use GitHub's classes it's because they do something. If the behavior is entirely controlled by us, then we use rgh- classes. It's true that technically we're replicating GitHub's behavior, but especially for that reason we should not reuse their classes in order to avoid future conflicts. |
ahead of schedule, aren't we
|
I expect sidebars to be rewritten soon. Let's see if they become natively sticky. If they do, I'll close this PR; if not, I'll update it |
It seems I overestimated their development speed |
2 participants
restores feature on PR (#8946) and repo root pages + cleanup
Test URLs
https://github.com/refined-github/refined-github
#755
Screenshot