Repository navigation
conversation-activity-filter - Fix sticky header overflow - #8966
Merged
Merged
Conversation
Member
|
Does this use CSS anchors? As long as it works in every browser it's fine. If you can test Firefox ESR that would give it further assurance (we don't follow/support ESR specifically, but I still try to if it's easy) |
Contributor
Author
|
This uses Example: https://github.com/refined-github/refined-github/releases/tag/26.2.2 
|
Contributor
Author
|
Also see: #8806 (comment) |
SunsetTechuila
force-pushed
the
filter-popover
branch
from
February 20, 2026 21:58
b6f35e9 to
7d6b30e
Compare
SunsetTechuila
marked this pull request as ready for review
February 26, 2026 16:45
Member
|
Can be merged as long as you tested it in a couple browsers and in "iPhone emulation" in Chrome. The main concern is how it behaves on touch/small viewports. |
fregante
approved these changes
Feb 27, 2026
Contributor
Author
|
Member
|
LGTM |
Merged
1 task done
typescript works with them better
SunsetTechuila
changed the title
conversation-activity-filter - Use popover for menuconversation-activity-filter - Fix sticky header overflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8967
Depends on #8953
Please say this is reviewable as a single commit 🙏
Test URLs
#4008
#4030
Screenshot