ci-link - Restore feature#8944
Conversation
blzsaa
force-pushed
the
fix-broken-ci-link
branch
from
fa23249 to
62660b6
Compare
blzsaa
force-pushed
the
fix-broken-ci-link
branch
from
62660b6 to
c75c0f7
Compare
Update the anchor according to the UI changes on GitHub.
blzsaa
force-pushed
the
fix-broken-ci-link
branch
from
c75c0f7 to
9d7f374
Compare
|
Please do not force-push without good reason. This creates noise and makes review process harder |
|
I decided it would be faster to commit the changes myself |
source/features/ci-link.tsx
Outdated
| await expectToken(); | ||
|
|
||
| observe([ | ||
| 'div[data-testid="top-nav-center"] li[class^="prc-Breadcrumbs-ItemWrapper"]:last-child a[class*="prc-Breadcrumbs-Item"]', |
There was a problem hiding this comment.
How many breadcrumbs are on the page? The first part of the selector seems redundant.
Maybe even the second one. How about li:last-child > a[class*="prc-Breadcrumbs-Item"]. Note the additional > since li could be any parent otherwise
There was a problem hiding this comment.
How many breadcrumbs are on the page?
Technically, these are breadcrumbs too, but yes, you can remove the div[data-testid="top-nav-center"] part - I just decided to play it safe
li:last-child > a[class*="prc-Breadcrumbs-Item"]
I like that
fregante
left a comment
fregante
left a comment
There was a problem hiding this comment.
Seems ok as long as it works only in the desktop view and it doesn't duplicate/break when the viewport is too small.
|
|
3 participants
Update the anchor according to the UI changes on GitHub.
closes #8943
Test URLs
https://github.com/refined-github/refined-github
Screenshot
Without this:
With this: