Highlight target disabled feature in settings#8918
Highlight target disabled feature in settings#8918SunsetTechuila wants to merge 15 commits intomainfrom
Conversation
SunsetTechuila
changed the title
This comment was marked as off-topic.
This comment was marked as off-topic.
| async function init(): Promise<void> { | ||
| await generateDom(); | ||
| addEventListeners(); | ||
| scrollTargetIntoView(); |
There was a problem hiding this comment.
No JS for this please: #8833 (comment)
See also the mention of scroll-margin a couple of comments above.
There was a problem hiding this comment.
There was a problem hiding this comment.
What browser is that? My gif in that comment shows it working in Chrome
There was a problem hiding this comment.
See also the mention of scroll-margin a couple of comments above.
I decided that scrolling to the center was better than setting scroll-margin-top to an arbitrary value
There was a problem hiding this comment.
"Better" is arbitrary, all :targets work like this on the web: the linked anchor appears at the top. Here we can also highlight it, which improves it further.
There was a problem hiding this comment.
What browser is that?
MS Edge. But I'm sure you'll get the same result with Chrome if you try this branch with scrollTargetIntoView commented
This comment was marked as resolved.
This comment was marked as resolved.
2 participants
resolves #8833
Test URLs
Screenshot