Skip to content

sticky-sidebar - Disable on natively-sticky sidebars#8696

Merged
fregante merged 3 commits into
refined-github:mainfrom
SunsetTechuila:sidebar
Oct 7, 2025
Merged

sticky-sidebar - Disable on natively-sticky sidebars#8696
fregante merged 3 commits into
refined-github:mainfrom
SunsetTechuila:sidebar

Conversation

@SunsetTechuila

@SunsetTechuila SunsetTechuila commented Oct 7, 2025

Copy link
Copy Markdown
Contributor

@SunsetTechuila

This comment was marked as off-topic.

@fregante fregante changed the title sticky-sidebar: don't process sidebars that are already sticky sticky-sidebar - Disable on natively-sticky sidebars Oct 7, 2025
Comment thread source/features/sticky-sidebar.tsx Outdated
Comment thread source/features/sticky-sidebar.tsx Outdated

@fregante fregante left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than that

@fregante fregante added the bug label Oct 7, 2025
@fregante

fregante commented Oct 7, 2025

Copy link
Copy Markdown
Member

If you see a regression, most likely GitHub changed/removed their testid

@fregante fregante merged commit 211e100 into refined-github:main Oct 7, 2025
9 checks passed
@SunsetTechuila SunsetTechuila deleted the sidebar branch October 7, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

sticky-sidebar misaligns the sidebar on short issues

2 participants