Skip to content

rgh-improve-new-issue-form - Restore feature - #8363

Merged
fregante merged 2 commits into
mainfrom
rgh-improve-new-issue-form-2
Mar 31, 2025
Merged

fregante merged 2 commits into
mainfrom
rgh-improve-new-issue-form-2

Conversation

@fregante

Copy link
Copy Markdown
Member

@fregante fregante added the bug label Mar 31, 2025
}

async function setVersion(): Promise<void> {
await delay(1000); // I give up https://github.com/refined-github/refined-github/issues/8296#issuecomment-2765270023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♂️
#8296 (comment)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this minor feature it's ok, I just wanted to fix it. Eventually we'll want to figure out better solutions.

node.textContent = node.textContent.replace(text, '');
}

export function getElementByAriaLabelledBy<T extends HTMLElement>(baseSelector: string, label: string): T {

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool new helper because GitHub developers don't know to create an HTML forms anymore

@fregante
fregante merged commit c026043 into main Mar 31, 2025
@fregante
fregante deleted the rgh-improve-new-issue-form-2 branch March 31, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

rgh-improve-new-issue-form: Expected element not found: input#issue_form_version

2 participants