Skip to content

Replace Gist links with embedded Gist #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sindresorhus merged 12 commits into from
Dec 12, 2017
Merged

Replace Gist links with embedded Gist #820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
2a4c254
Replace gist links with embedded gist
donocode Nov 16, 2017
8bc8950
convert spaces to tabs
donocode Nov 17, 2017
869572b
address simple review comments
donocode Nov 17, 2017
50f2249
use JSX for gist element
donocode Nov 20, 2017
63afc62
Update embed-gist-inline.js
sindresorhus Nov 26, 2017
5518228
minor review changes
donocode Dec 6, 2017
4a3c18b
Merge branch 'master' into embed-gist
donocode Dec 6, 2017
0452cf4
fix xo lint errors
donocode Dec 6, 2017
9329687
Fix; Use Shadow DOM version; Exclude embeds
fregante Dec 7, 2017
e34d37e
Merge remote-tracking branch 'origin/master' into donocode-embed-gist
fregante Dec 7, 2017
77181d5
switch json url to template string
donocode Dec 12, 2017
cf726ac
add screenshot to new features
donocode Dec 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ GitHub Enterprise is also supported by [authorizing your own domain in the optio
- Copy canonical link to file when [the <kbd>y</kbd> hotkey](https://help.github.com/articles/getting-permanent-links-to-files/) is used
- Supports indenting with the tab key in textareas like the comment box (<kbd>Shift</kbd> <kbd>Tab</kbd> for original behavior)
- [Uses the pull request title as commit title when merging with 'Squash and merge'](https://github.com/sindresorhus/refined-github/issues/276)
- [Replaces linked gists in issue and pull request comments with an embedded version of the gist file](https://user-images.githubusercontent.com/6978877/33911900-c62ee968-df8b-11e7-8685-506ffafc60b4.PNG)

### More actions

Expand Down
2 changes: 2 additions & 0 deletions source/content.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ import focusConfirmationButtons from './features/focus-confirmation-buttons';
import addKeyboardShortcutsToCommentFields from './features/add-keyboard-shortcuts-to-comment-fields';
import addConfirmationToCommentCancellation from './features/add-confirmation-to-comment-cancellation';
import addCILink from './features/add-ci-link';
import embedGistInline from './features/embed-gist-inline';
import expandCollapseOutdatedComments from './features/expand-collapse-outdated-comments';

import * as pageDetect from './libs/page-detect';
Expand Down Expand Up @@ -161,6 +162,7 @@ function ajaxedPagesHandler() {
if (pageDetect.isPR() || pageDetect.isIssue()) {
safely(linkifyIssuesInTitles);
safely(addUploadBtn);
safely(embedGistInline);

observeEl('.new-discussion-timeline', () => {
safely(addOPLabels);
Expand Down
28 changes: 28 additions & 0 deletions source/features/embed-gist-inline.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
import {h} from 'dom-chef';
import select from 'select-dom';

const isGist = link =>
!link.pathname.includes('.') && // Exclude links to embed files
(
link.hostname.startsWith('gist.') ||
link.pathname.startsWith('gist/')
);

const createGistElement = gistData => (
<div>
<link rel="stylesheet" href={gistData.stylesheet} />
<div dangerouslySetInnerHTML={{__html: gistData.div}} />
</div>
);

async function embedGist(link) {
const response = await fetch(`${link.href}.json`);
const gistData = await response.json();
const gistEl = createGistElement(gistData);
link.parentNode.attachShadow({mode: 'open'}).append(gistEl);
}
export default () => {
select.all('.js-comment-body p a:only-child')
.filter(isGist)
.forEach(embedGist);
};