Skip to content

Hide Github's Footer#755

Closed
CrowderSoup wants to merge 1 commit into
refined-github:masterfrom
CrowderSoup:bug/hideGithubFooter
Closed

Hide Github's Footer#755
CrowderSoup wants to merge 1 commit into
refined-github:masterfrom
CrowderSoup:bug/hideGithubFooter

Conversation

@CrowderSoup

Copy link
Copy Markdown
Contributor

Github's footer should be hidden. This updates the style to ensure that
it is.

Fixes #753

Github's footer should be hidden. This updates the style to ensure that
it is.
@fregante

Copy link
Copy Markdown
Member

This leaves no padding at the bottom of the page, it might need more work now

screen shot 2017-10-23 at 13 22 17

@yakov116

Copy link
Copy Markdown
Member

@bfred-it @CrowderSoup Can we reconsider this? As you have 3 useful link at the bottom that I use from time to time.

One is the "Status" and one is "API" and one is "Contact Github". I don't really see how this get in the way its not like it add's space to the page.

@fregante

fregante commented Oct 23, 2017

Copy link
Copy Markdown
Member

I thought about that, it depends on how much you actually use it. Status has little use because if you see the link… GitHub works! So you just Google it when it doesn’t.

Same goes for contact and API, I contact them once a year and the API can be found via Google as well. If you use it more often than that it’s probably gonna be in your browser history. Either way I doubt it’s faster to load GitHub.com, scroll to the bottom, and click on a link with a mouse than it is to just Google it.

@yakov116

Copy link
Copy Markdown
Member

@bfred-it You're right... I use it daily 😄 because I use the api for many things.

@hkdobrev

Copy link
Copy Markdown
Contributor

The browser address bar is much quicker for these as @bfred-it mentioned.

You could just type github status in Chrome omnibox and it would suggest you the right page if you've visited it before.

@busches

busches commented Oct 24, 2017

Copy link
Copy Markdown
Member

@hkdobrev I have to disagree on browser search always being faster. Also, browser search doesn't work for GHE.

@fregante

Copy link
Copy Markdown
Member

What GHE-specific links do you have on GHE? It feels like none of that applies to GHE at all.

@busches

busches commented Oct 24, 2017

Copy link
Copy Markdown
Member

@bfred-it mainly the GitHub API link, as we are not always on the latest and greatest version and that's a quick and easy way to find out what version we're on.

@hkdobrev

hkdobrev commented Oct 25, 2017

Copy link
Copy Markdown
Contributor

@busches I'm interested to see how the footer looks on GHE. Could you please post a screenshot? Thank you!

@fregante fregante added the bug label Oct 25, 2017
@derimagia

Copy link
Copy Markdown

screen shot 2017-10-29 at 12 13 27 pm

Everything links to Github proper, (API and Help link to the specific version of the api/site -
https://developer.github.com/enterprise/2.11/ for example).
Support is an email link to the admin of the hosted instance.

@hkdobrev

hkdobrev commented Oct 30, 2017

Copy link
Copy Markdown
Contributor

What do you guys thinking about reducing the footer to just this?

  • On GitHub.com - a simple line saying © GitHub, Inc. with Refined GitHub extension version ...
  • On GHE - a simple line saying GitHub enterprise version ... and Refined GitHub extension version ...

@ramlmn

ramlmn commented Oct 30, 2017

Copy link
Copy Markdown

@hkdobrev I think we should also not remove Terms and Privacy links. 🤷‍♀️

@fregante

Copy link
Copy Markdown
Member

Honestly at this point I’d leave it. I don’t see many reasons to remove it, especially if we end up leaving some links and discussing which links to leave to whom.

@hkdobrev

Copy link
Copy Markdown
Contributor

I don't mind it much, having some footer on some pages is useful. If we can make it more minimal, though, that would be great.

@sindresorhus I think you were the one who removed the footer initially. What do you think about that?

@sindresorhus

Copy link
Copy Markdown
Member

I'm neutral. I've never used the footer even once, but it doesn't bother me either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

8 participants