-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Replace Webpack with Rollup #7472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
| styles(), | ||
| string({ | ||
| include: '**/*.gql', | ||
| }), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could use a GQL-specific plugin in the future, but for now it's 1:1 for easier upgrade.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment was marked as outdated.
This comment was marked as outdated.
|
Wah… have we finally reached this point? It appears to work 😱 I've been trying to move off of Webpack for years and we've finally come full circle: Complexity-wise, the advantages of Rollup over Webpack are minor or non-existent, but we gain the ability to output separate files. This means we will be able to drop hacks like These improvements can come later, when our new Rollup build has been validated. |
|
A couple of warnings: |
|
@kidonng @yakov116 does anyone of you run a dev version daily? It would be good to test-drive this version as your daily version. @busches it would be particularly good to check for regressions on GHE as well. I didn't see issues but I'm nervous to merge it 😅 A pre-built version can be found at the bottom of the artifacts page: https://github.com/refined-github/refined-github/actions/runs/10530672758?pr=7472 |
|
I can use it for the next few days |
This reverts commit a433639.
instead of node_modules/dom-chef/dist/index.js, which appears as "index.js" in console errors, it's created as node_modules/dom-chef.js


import.meta.url) #6609preserveModules, but one bundle per node_module rollup/rollup#5626I'm interested in Rollup's ability to spit out independent files instead of a single bundle.
This is not done yet, it's having issues with the .d.ts import rollup/plugins#992