Ensure hide-user-forks works coming from anywhere#6531
Merged
Conversation
fregante
commented
Apr 16, 2023
fregante
commented
Apr 16, 2023
Member
Author
There was a problem hiding this comment.
I had added and subsequently dropped refined-github/github-url-detection#170
The selectors are super specific and the alteration is non-destructive
/**?tab=repositories
/orgs/**/repositories/
The first one is relatively broad (it could target /user/repo/settings/access?tab=repositories, if it ever exists), but until we found out, the bug would likely be silent anyway.
kidonng
reviewed
Apr 16, 2023
kidonng
reviewed
Apr 16, 2023
Co-authored-by: Kid <44045911+kidonng@users.noreply.github.com>
Co-authored-by: Kid <44045911+kidonng@users.noreply.github.com>
This was referenced Apr 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hide-user-forksmissing from some links #6464hide-user-forkson more links #6466Test URLs
Screenshot