Skip to content

Run clear-pr-merge-commit-message only once per load#6330

Merged
fregante merged 2 commits intomainfrom
duplicate-clear-pr-merge-commit-message-note
Feb 11, 2023
Merged

Run clear-pr-merge-commit-message only once per load#6330
fregante merged 2 commits intomainfrom
duplicate-clear-pr-merge-commit-message-note

Conversation

@fregante
Copy link
Member

@fregante fregante commented Feb 11, 2023

Opening the merge box multiple times could cause multiple notes to be injected. The field also lost any user-customized content every time the form was opened.

Screenshot 2

Test URLs

refined-github/sandbox#55

Before After
Screen.Recording.1.mov
Screen.Recording.2.mov

@fregante fregante added the bug label Feb 11, 2023
@fregante fregante changed the title Run clear-pr-merge-commit-message only once Run clear-pr-merge-commit-message only once per load Feb 11, 2023
@fregante fregante merged commit 6914b06 into main Feb 11, 2023
@fregante fregante deleted the duplicate-clear-pr-merge-commit-message-note branch February 11, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

1 participant