Skip to content

Polish latest-tag-button #5773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fregante merged 1 commit into from
Jul 5, 2022
Merged

Polish latest-tag-button #5773

fregante merged 1 commit into from
Jul 5, 2022

Conversation

@fregante
Copy link
Member

@fregante fregante commented Jul 4, 2022

  1. Use compare icon, not commit/diff: https://github.com/pixiebrix/pixiebrix-extension/compare/main
  2. Drop useless indicator: if we show the compare link, then it's "behind"; Saying "I don't know how behind" isn't necessary

Test URLs

Before

Screen Shot 2Screen Shot 3

After

Screen ShotScreen Shot

@fregante fregante merged commit 1cf92af into main Jul 5, 2022
@fregante fregante deleted the latest-tag-button branch July 5, 2022 15:22
@kidonng
Copy link
Member

kidonng commented Jul 5, 2022

2. Drop useless indicator: if we show the compare link, then it's "behind"; Saying "I don't know how behind" isn't necessary

Reference: #5505 (comment)

@fregante
Copy link
Member Author

fregante commented Jul 5, 2022 •
edited
Loading

?

We had the indicator since the beginning for a while. That PR only changed it

@kidonng
Copy link
Member

kidonng commented Jul 5, 2022

I just mentioned when the asterisk is added, because myself haven't really seen (or noticed) it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

change request

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fregante @kidonng