Meta: Disable checkboxes of hotfixed features #4987
Conversation
fregante
changed the title
fregante
left a comment
fregante
left a comment
There was a problem hiding this comment.
On second thought, I avoided changing this in most cases because we want the user to be able to disable them (if the hotfix is also failing). Just because there's a hotfix active, it doesn't mean we should lock the interface. Maybe the only think we can do is to gray the whole line out
But that's probably not going to happen randomly, and the way we disable the checkboxes means it only triggers if (most part of) hotfix still works.
We used to disable the checkbox altogether, until #3678 changed the settings page. |
True, but I still don't like inactive checkboxes that have no reason to. Even if the checkbox isn't immediately followed, we do show why that's happening and dim the whole line to show something is wrong. |
There's a reason clearly written in the notice: the feature is disabled.
Did you mean we should restore the old appearance?
With your suggestion, |
I mean we don't have a reason to. Just because the feature is disabled it doesn't mean we should also stop the user from toggling it for when it's fixed. |
The only situation I can see a user needing to toggle is if they are transferring their setting from one computer to the next. I happen to not see an issue with the whole line being disabled. JMHO |
|
If the user scrolls down and doesn't notice/remember the hotfix message, they may wonder why toggling those features doesn't work. Yeah I know this is some hypothetical situation but AFAICT the checkboxes had been disabled for the longest time. It's just the behavior wasn't keep in the refactor PR (and not restored later). |
|
Let's release a new version on the 10th. Feel free to merge any approved PRs or review others’ |
There was a problem hiding this comment.
Changed my mind again. All your arguments still apply to the current situation, mainly:
If the user scrolls down and doesn't notice/remember the hotfix message, they may wonder why toggling those features doesn't work.
Same exact thing applies now; additionally the checkbox does not respond to clicks at all, i.e. the checkbox itself is broken.
Looking at your screenshot: The checkbox barely looks disabled at all.
I see 2 improvements possible, if you want to pick this up:
- dim the whole line as suggested earlier
- add the reason why it's dimmed inline, like it was before (in addition to the header)
|
Closing for now, it can be opened when there are commits |
4 participants
Resolve #4974
Test URLs
Note: to test it you need to change
versionto21.10.18inmanifest.json.chrome://extensions/?options=balgliakcbamepammkbcjdepogihccmj
Screenshot
Before:
After: