Maybe instead of checking if each details contains a .comment-body, it'd be more efficient to select those and then use .closest('details').

Also a note on hidden review comments: they're not loaded with the page, but only when first expanded... except when the link has a hash pointing to a review comment in the same discussion:

• this will load the hidden comments: Add comment-on-draft-pr-indicator feature #4520 (comment)
• this will not: Add comment-on-draft-pr-indicator feature #4520

Also a note on hidden review comments: they're not loaded with the page, but only when first expanded... except when the link has a hash pointing to a review comment in the same discussion:

In that case it's no longer hidden, which we don't care about.

If they're all hidden, then they should just be excluded, right?

In that case it's no longer hidden, which we don't care about.

Just to be perfectly clear: hidden review comments do get loaded without needing to be opened first (meaning they can be previewed), but only when focusing another review comment in the same subthread (e.g. when following a link ending with #discussion_r<id>).

In all other cases the feature would be almost useless, since the comments need to be loaded first by opening them. (One could argue that it might be useful to be able to preview comments that have been opened up and then hidden again, if there's a lot of them.)

Can you update the JS comment with this information? It makes it sounds like all review comments are to be excluded

Maybe instead of checking if each details contains a .comment-body, it'd be more efficient to select those directly and then use .closest('details')

Thoughts?

Maybe instead of checking if each details contains a .comment-body, it'd be more efficient to select those and then use .closest('details').

Yes 👍