Meta: Fix rgh-feature-descriptions feature#4818
Merged
fregante merged 5 commits intorefined-github:mainfrom Oct 1, 2021
gamemaker1:fix/rgh-feature-descriptions
Merged
Meta: Fix rgh-feature-descriptions feature#4818fregante merged 5 commits intorefined-github:mainfrom gamemaker1:fix/rgh-feature-descriptions
rgh-feature-descriptions feature#4818fregante merged 5 commits intorefined-github:mainfrom
gamemaker1:fix/rgh-feature-descriptions
Conversation
gamemaker1
commented
Sep 25, 2021
Member
|
If they're cross-compatible, let's keep the 3 selectors so we don't have to go back and forth for now. Also it's best to use a selector array with a comment after each selector |
rgh-feature-descriptions feature
Contributor
Author
|
Member
|
Member
|
I went back to look at the old PR: The selector was only broken back then because they had dropped the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the selector to select the commit box to
.Box-header.Details, as suggested in #4815 (comment).Closes #4815 if merged.