Skip to content

Meta: Fix rgh-feature-descriptions feature#4818

Merged
fregante merged 5 commits intorefined-github:mainfrom
gamemaker1:fix/rgh-feature-descriptions
Oct 1, 2021
Merged

Meta: Fix rgh-feature-descriptions feature#4818
fregante merged 5 commits intorefined-github:mainfrom
gamemaker1:fix/rgh-feature-descriptions

Conversation

@gamemaker1
Copy link
Contributor

@gamemaker1 gamemaker1 commented Sep 25, 2021

Changes the selector to select the commit box to .Box-header.Details, as suggested in #4815 (comment).

Closes #4815 if merged.

@fregante
Copy link
Member

If they're cross-compatible, let's keep the 3 selectors so we don't have to go back and forth for now. Also it's best to use a selector array with a comment after each selector

@fregante fregante added bug meta Related to Refined GitHub itself labels Sep 25, 2021
@fregante fregante changed the title Fix rgh-feature-descriptions feature Meta: Fix rgh-feature-descriptions feature Sep 25, 2021
@gamemaker1
Copy link
Contributor Author

... selector array with a comment after each selector

elementReady doesn't seem to accept an array. Anything I'm missing?

@fregante
Copy link
Member

fregante commented Sep 26, 2021

... selector array with a comment after each selector

elementReady doesn't seem to accept an array. Anything I'm missing?

elementReady(['a', 'b'].join(','))

@gamemaker1 gamemaker1 marked this pull request as ready for review September 26, 2021 11:38
@fregante
Copy link
Member

fregante commented Oct 1, 2021

I went back to look at the old PR: The selector was only broken back then because they had dropped the --blue class, but was otherwise valid as a generic "Box" selector. In short, the hx class was never needed.

@fregante fregante merged commit 5a272a7 into refined-github:main Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug meta Related to Refined GitHub itself

Development

Successfully merging this pull request may close these issues.

rgh-feature-descriptions is broken

3 participants