Restore parse-backticks on Discussions#4765
Merged
fregante merged 1 commit intorefined-github:mainfrom Sep 9, 2021
darkred:fix-parse-backticks-on-discussions
Merged
Restore parse-backticks on Discussions#4765fregante merged 1 commit intorefined-github:mainfrom darkred:fix-parse-backticks-on-discussions
parse-backticks on Discussions#4765fregante merged 1 commit intorefined-github:mainfrom
darkred:fix-parse-backticks-on-discussions
Conversation
fregante
approved these changes
Sep 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3975 finally
Test URLs
tophf/mpiv#50
Screenshot
Notes to reviewers:
The
.js-issue-titleselector for Discussion page titles of my PR #3977 had to be removed, in PR #4136 (comment).Following #3975 (comment), the selector in this PR,
.js-discussions-title-container h1 > .js-issue-titlematches (once) in discussion pages, and it doesn't matches in issue pages.
If I remove the
h1 >part then it matches twice in discussion pages (i.e. also in a hidden element).