Skip to content

Fix rgh-feature-descriptions feature#4732

Merged
fregante merged 3 commits intorefined-github:mainfrom
gamemaker1:fix/rgh-feature-desc
Sep 1, 2021
Merged

Fix rgh-feature-descriptions feature#4732
fregante merged 3 commits intorefined-github:mainfrom
gamemaker1:fix/rgh-feature-desc

Conversation

@gamemaker1
Copy link
Contributor

@gamemaker1 gamemaker1 commented Aug 28, 2021

Related issues

Closes #4697 if merged.

What this PR does

Changes the CSS selector used to add the feature description box on RGH feature pages from .Box-header--blue.Details, include-fragment.commit-loader to .hx_commit-tease

Test URLs

https://github.com/sindresorhus/refined-github/blob/main/source/features/reactions-avatars.tsx
https://github.com/sindresorhus/refined-github/blob/main/source/features/clean-conversation-headers.tsx

@gamemaker1 gamemaker1 changed the title Fix: rgh-feature-descriptions is broken Fix: [rgh-feature-descriptions](https://github.com/sindresorhus/refined-github/blob/main/source/features/rgh-feature-descriptions.tsx) is broken Aug 28, 2021
@gamemaker1 gamemaker1 changed the title Fix: [rgh-feature-descriptions](https://github.com/sindresorhus/refined-github/blob/main/source/features/rgh-feature-descriptions.tsx) is broken Fix: rgh-feature-descriptions is broken Aug 28, 2021
@gamemaker1 gamemaker1 changed the title Fix: rgh-feature-descriptions is broken Fix: rgh-feature-descriptions is broken Aug 28, 2021
@gamemaker1 gamemaker1 changed the title Fix: rgh-feature-descriptions is broken Fix: rgh-feature-descriptions is broken Aug 28, 2021
@kidonng
Copy link
Member

kidonng commented Aug 28, 2021

Did you test in Safari? Doesn't seem like a simple selector change can fix it

@gamemaker1
Copy link
Contributor Author

gamemaker1 commented Aug 28, 2021

I don't think it is because of the browser, it happens for me on Firefox as well:

Before

image

After

image

Did you test in Safari

No, I am on Linux

@kidonng
Copy link
Member

kidonng commented Aug 28, 2021

Yup, you are right, I now see the error on Chrome as well:
image

@fregante
Copy link
Member

fregante commented Aug 28, 2021

The feature still works on some pages but not others. Make sure that they all still work after this PR: https://github.com/sindresorhus/refined-github/blob/main/source/features/clean-conversation-headers.tsx

I don't understand why it works only on some pages, what's missing and why? mmm

@gamemaker1
Copy link
Contributor Author

gamemaker1 commented Aug 28, 2021

Will test on all

Update: I checked around half the features folder (around 100) - all except the css-only features have a description box next to them with this fix.

@gamemaker1
Copy link
Contributor Author

I thought it might have been because of an update - I didn't see any of the previous selectors when inspecting the HTML

@gamemaker1
Copy link
Contributor Author

Tested it on pretty much all features now (and discovered that firefox does not crash with almost 200 tabs open - yay 😅🎉) - it works! Any other changes to be made?

@yakov116 yakov116 changed the title Fix: rgh-feature-descriptions is broken Fix rgh-feature-descriptions feature Aug 29, 2021
Copy link
Member

@fregante fregante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@fregante fregante merged commit fafef46 into refined-github:main Sep 1, 2021
@fregante fregante added bug meta Related to Refined GitHub itself labels Sep 1, 2021
@kidonng kidonng mentioned this pull request Sep 25, 2021
1 task
@gamemaker1 gamemaker1 deleted the fix/rgh-feature-desc branch September 26, 2021 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug meta Related to Refined GitHub itself

Development

Successfully merging this pull request may close these issues.

rgh-feature-descriptions is broken on reactions-avatars

3 participants